Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The example directory seems useless? #25

Closed
mithro opened this issue Jun 19, 2020 · 2 comments · Fixed by #47
Closed

The example directory seems useless? #25

mithro opened this issue Jun 19, 2020 · 2 comments · Fixed by #47
Assignees
@pgielda @kgugala

Comments

@mithro
Copy link
Contributor

mithro commented Jun 19, 2020

Currently we have

  • symbiflow-examples/examples/xc7

The extra examples directory doesn't seem to add much value?

It would probably be better to have the following

  • symbiflow-examples/xc7

It also means that a person who goes to this repo quickly sees which architectures there are examples for.
@mithro
Copy link
Contributor Author

mithro commented Jun 19, 2020

@pgielda / @kgugala What do you think?

@pgielda
Copy link
Member

pgielda commented Jun 19, 2020

Not sure. The thing is that xc7, eos-s3 (and potentially other names in the future) will pile up that is one thing, second the idea with "examples" is to make clear that this is where the examples are (and not e.g. some arch data needed for the scripts, etc).

In any case I do not have any strong opinions about it in any case so we can as well remove it.

@mithro mithro mentioned this issue Jul 29, 2020
Closed
@kamilrakoczy kamilrakoczy mentioned this issue Sep 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pgielda pgielda

@kgugala kgugala

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@mithro @pgielda @kgugala