Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

displaylink: 5.2.14 -> 5.3.1 #91129

Closed
wants to merge 1 commit into from
Closed

displaylink: 5.2.14 -> 5.3.1 #91129

wants to merge 1 commit into from

Conversation

Luabee
Copy link

@Luabee Luabee commented Jun 19, 2020

Motivation for this change

DisplayLink driver is failing to build on my device. Found this:

@Luc45 Just something I noticed in your combinations of tries, DisplayLink 5.2.14 does not work with evdi 1.7.0. You need the latest DisplayLink drivers which is 5.3.1 if you are installing evdi 1.7.0.

Originally posted by @elguero in DisplayLink/evdi#199 (comment)

I don't know how to test this change. I'm trying to get it to build on my own device. How can I use my local nixpkgs over the nixos channel?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nshalman
Copy link
Member

My test setup for this hardware is currently down. I'll try to carve out some time to turn it back on again and provide feedback.
In the meantime, you should be able to test it locally like so:

nixos-rebuild -I nixpkgs=/path/to/your/local/nixpkgs/tree switch 

@peterhoeg peterhoeg changed the title Bump DisplayLink driver displaylink: 5.2.14 -> 5.3.1 Jun 24, 2020
@eyJhb eyJhb mentioned this pull request Jul 11, 2020
10 tasks
@nshalman
Copy link
Member

I have tested the combination of #92917 and #92918. Once they land this PR should be a no-op and safe to close.
I wish I'd had time to fire up the setup sooner for you, but better late than never I guess...

@eyJhb
Copy link
Member

eyJhb commented Dec 12, 2020

Closing because of #92918

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants