Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode, vscodium: 1.46.0 -> 1.46.1 #91127

Merged
merged 1 commit into from Jun 27, 2020
Merged

vscode, vscodium: 1.46.0 -> 1.46.1 #91127

merged 1 commit into from Jun 27, 2020

Conversation

kuznero
Copy link
Member

@kuznero kuznero commented Jun 19, 2020

Motivation for this change

Upgrade vscode, vscodium packages

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from eadwu and Synthetica9 June 19, 2020 22:26
@kuznero
Copy link
Member Author

kuznero commented Jun 20, 2020

It's ready to be merged.

eadwu
eadwu approved these changes Jun 20, 2020
View reviewed changes
Copy link
Member

@eadwu eadwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified hashes.

❯ version="1.46.1"
❯ plat="linux-x64"
❯ archive_fmt="tar.gz"
❯ nix-prefetch-url "https://vscode-update.azurewebsites.net/${version}/${plat}/stable"
path is '/nix/store/s13ah6ni9m13fh0z2x65cpvhf2iiip7x-stable'
1c8gi2001p2f0zc165cqwwf9f8ls34fgg040qn9l08za7djb9hyv
❯ nix-prefetch-url "https://github.com/VSCodium/vscodium/releases/download/${version}/VSCodium-${plat}-${version}.${archive_fmt}"
path is '/nix/store/gfjdzw1ibyma7r8qzsyfky695ifm9p1k-VSCodium-linux-x64-1.46.1.tar.gz'
0l9sg2d0657k9dacy7k2jn8z07z50v8d1czgy4bkzbrj9vz7c6a7
❯ plat="darwin"
❯ archive_fmt="zip"
❯ nix-prefetch-url "https://vscode-update.azurewebsites.net/${version}/${plat}/stable"
path is '/nix/store/sxc5rwcyz9zmzhjjyfgkp36275mzkcbk-stable'
06n17s3qa2jkmg5qx3zvshz6rvdx33dhxn65j0x5mi62dv93gjgg
❯ nix-prefetch-url "https://github.com/VSCodium/vscodium/releases/download/${version}/VSCodium-${plat}-${version}.${archive_fmt}"
path is '/nix/store/90ibsfk29i6r5rw4lzya4rhf6s6yckl2-VSCodium-darwin-1.46.1.zip'
0mnq0ykahwfrgs28rdy1jl366qyclipsr3apnmhym1xsylk0mpfx

@kuznero
Copy link
Member Author

kuznero commented Jun 22, 2020

Please merge

@kuznero
Copy link
Member Author

kuznero commented Jun 22, 2020

Is there any way to automate these type of changes (such that it potentially can get through faster without manual intervention)?

@kuznero
Copy link
Member Author

kuznero commented Jun 23, 2020

@Mic92, @Synthetica9 please merge. Is there any way to automate this process somehow?

@kuznero
Copy link
Member Author

kuznero commented Jun 26, 2020

Any chance to get it merged? Is there a possibility to get a merge right (not sure if possible for a subtree somehow)?

@Mic92 Mic92 merged commit 32b95b2 into NixOS:master Jun 27, 2020
@kuznero kuznero deleted the vscode branch July 10, 2020 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eadwu eadwu eadwu approved these changes

@Synthetica9 Synthetica9 Awaiting requested review from Synthetica9

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kuznero @eadwu @Mic92