Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/resilio: listen on [::1] by default #91128

Merged
merged 1 commit into from Jun 20, 2020
Merged

nixos/resilio: listen on [::1] by default #91128

merged 1 commit into from Jun 20, 2020

Conversation

bbigras
Copy link
Contributor

@bbigras bbigras commented Jun 19, 2020

Motivation for this change

fix #54482

Things done

I tested that it's listening on [::1] with the ss command.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

maybe @Mic92

@bbigras
Copy link
Contributor Author

bbigras commented Jun 20, 2020

/marvin opt-in

@marvin-mk2
Copy link

marvin-mk2 bot commented Jun 20, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@marvin-mk2 marvin-mk2 bot added the marvin label Jun 20, 2020
@bbigras
Copy link
Contributor Author

bbigras commented Jun 20, 2020

/status needs_review

rnhmjoj
rnhmjoj requested changes Jun 20, 2020
View reviewed changes
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, however this is a breaking change: I would mention this in the release notes.

@bbigras
Copy link
Contributor Author

bbigras commented Jun 20, 2020

Done. It's the first time I edited one of those docbook xml files, so I'm not sure if I did it right.

rnhmjoj
rnhmjoj approved these changes Jun 20, 2020
View reviewed changes
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, the manual looks good.

@rnhmjoj rnhmjoj merged commit 1eef920 into NixOS:master Jun 20, 2020
@bbigras bbigras deleted the rslsync-localhost branch June 20, 2020 18:48
@bbigras
Copy link
Contributor Author

bbigras commented Jun 20, 2020

Thanks!

@marvin-mk2 marvin-mk2 bot requested a review from timokau July 3, 2020 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnhmjoj rnhmjoj rnhmjoj approved these changes

@timokau timokau Awaiting requested review from timokau

Assignees
No one assigned
Labels
6.topic: nixos 8.has: changelog 8.has: documentation 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 awaiting_reviewer marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

resilio sync listen to 0.0.0.0 by default
2 participants
@bbigras @rnhmjoj