Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.utc: unbreak #91103

Merged
merged 1 commit into from Jun 20, 2020
Merged

haskellPackages.utc: unbreak #91103

merged 1 commit into from Jun 20, 2020

Conversation

sternenseemann
Copy link
Member

Motivation for this change

Fix simple version constraint issue preventing utc from building

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@peti peti force-pushed the haskell-updates branch 3 times, most recently from 02f9eb5 to 881e0cf Compare June 19, 2020 20:29
@cdepillabout
Copy link
Member

@sternenseemann Thanks for this PR.

Could you do a couple things:

  • Rebase your commit onto the head of the haskell-updates branch. (It looks like an unfortunate timing that right after you sent this, the haskell-updates branch was updated).
  • Create an issue on the upstream repo asking for a new release to hackage (and put that link right into the nix code below the comment you've already added).

Once you do these two things, I'll be happy to merge this in.

@sternenseemann
Copy link
Member Author

@cdepillabout should all be resolved now!

@cdepillabout
Copy link
Member

Builds for me, thanks for fixing this up!

@cdepillabout cdepillabout merged commit e6ba9ab into NixOS:haskell-updates Jun 20, 2020
@sternenseemann sternenseemann deleted the unbreak-utc branch June 21, 2020 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sternenseemann @cdepillabout