Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alda: init at 1.4.2 #91176

Merged
merged 1 commit into from Aug 18, 2020
Merged

alda: init at 1.4.2 #91176

merged 1 commit into from Aug 18, 2020

Conversation

ericdallo
Copy link
Member

Motivation for this change

Add Alda programming language

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ericdallo
Copy link
Member Author

FYI @daveyarwood, we can add this later on README on how to install on NixOS

@daveyarwood
Copy link

@ericdallo This is really awesome, thanks for putting this together!

Let me know if I can help at any point if any issues come up in the maintenance of this package.

markuskowa
markuskowa reviewed Jun 28, 2020
View reviewed changes
pkgs/development/interpreters/alda/default.nix
pname = "alda";
version = "1.4.2";

src = fetchurl {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use fetchFromGitHub here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markuskowa in this case we download the binary from the github releases page

@markuskowa markuskowa merged commit ff592bf into NixOS:master Aug 18, 2020
@ericdallo ericdallo deleted the add-alda branch August 19, 2020 00:32
@ericdallo ericdallo mentioned this pull request Aug 19, 2020
Closed
@ericdallo ericdallo mentioned this pull request Sep 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markuskowa markuskowa markuskowa left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ericdallo @daveyarwood @markuskowa