Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3: improve cross-compilation of extension modules, fixes #91171 #91178

Merged
merged 2 commits into from Jun 22, 2020
Merged

python3: improve cross-compilation of extension modules, fixes #91171 #91178

merged 2 commits into from Jun 22, 2020

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Jun 20, 2020 •
edited

Fixes #91171.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh FRidh changed the base branch from master to staging June 20, 2020 15:43
@FRidh

This comment has been minimized.

Sign in to view
@primeos primeos mentioned this pull request Jun 20, 2020
Closed
10 tasks
@FRidh

This comment has been minimized.

Sign in to view
@FRidh
Copy link
Member Author

FRidh commented Jun 20, 2020

Upstream PR!
python/cpython#7914

@FRidh FRidh marked this pull request as ready for review June 21, 2020 09:57
@Mic92
Copy link
Member

Mic92 commented Jun 21, 2020

Downside of this approach is that it only works in a nix-build or nix-shell.

This is not really a regression compilers don't work outside the nix-shell anyway.

@FRidh
Copy link
Member Author

FRidh commented Jun 21, 2020

Doesn't mean we need to enforce that shortcoming when we can avoid it.

@Mic92
Copy link
Member

Mic92 commented Jun 21, 2020

Doesn't mean we need to enforce that shortcoming when we can avoid it.

It should be easy enough to whatever one wants to use instead of nix-shell to also just export LDSHARED, CC, and CXX accordingly.

@FRidh
python3: improve cross-compilation of extension modules, fixes NixOS#…
f03734e 
…91171
@FRidh
btrfs-progs: remove LDSHARED
82f1704 
This should no longer be needed with python3 because it's now
set correctly in the interpreter.

Note that the build currently fails with and without this change.
@FRidh
Copy link
Member Author

FRidh commented Jun 21, 2020

Exactly.

So, as it is now cross-compiling pycryptodome succeeds. I also tried btrfs-progs because it exports LDSHARED, but unfortunately that package fails to build with and without the patch in this PR.

@FRidh FRidh added the 6.topic: cross-compilation Building packages on a different sort platform than than they will be run on label Jun 21, 2020
@ofborg ofborg bot requested a review from 7c6f434c June 21, 2020 15:41
@Mic92
Copy link
Member

Mic92 commented Jun 21, 2020

There is a report that btrfs-progs cross-compiles now as of #50925 (comment)

@FRidh FRidh merged commit 9c3a585 into NixOS:staging Jun 22, 2020
@FRidh FRidh deleted the ldshared branch June 22, 2020 06:47
@Thra11 Thra11 mentioned this pull request Jul 4, 2020
Closed
This was referenced Jul 5, 2020
Closed
Closed
@kvtb
Copy link
Contributor

kvtb commented Jul 10, 2021

@GrahamcOfBorg build pkgsCross.aarch64-multiplatform.python3Packages.pycryptodome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knedlsepp knedlsepp Awaiting requested review from knedlsepp

@primeos primeos Awaiting requested review from primeos

@Mic92 Mic92 Awaiting requested review from Mic92

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
6.topic: cross-compilation Building packages on a different sort platform than than they will be run on 6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 10.rebuild-linux-stdenv 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@FRidh @Mic92 @kvtb