Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

influxdb,lexicon: fix builds #91180

Merged
merged 11 commits into from Jun 22, 2020
Merged

influxdb,lexicon: fix builds #91180

merged 11 commits into from Jun 22, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Jun 20, 2020 •
edited

Motivation for this change

fix lexicon and influxdb builds, which were failing on a different review

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer requested a review from FRidh as a code owner June 20, 2020 16:53
@ofborg ofborg bot requested a review from rvl June 20, 2020 17:00
@jonringer
Copy link
Contributor Author 

https://github.com/NixOS/nixpkgs/pull/91180
6 packages failed to build:
ape pantalaimon python37Packages.nvchecker python37Packages.sunpy python38Packages.nvchecker python38Packages.sunpy

22 packages built:
lexicon python27Packages.influxdb python27Packages.requests-file python27Packages.tldextract python37Packages.aioresponses python37Packages.graphite_api python37Packages.influxdb python37Packages.influxgraph python37Packages.requests-file python37Packages.structlog python37Packages.tldextract python37Packages.zeep python38Packages.aioresponses python38Packages.graphite_api python38Packages.influxdb python38Packages.influxgraph python38Packages.requests-file python38Packages.structlog python38Packages.tldextract python38Packages.zeep qutebrowser sewer

a few of the packages are fixed by #89694 , going to merge that PR first

@ofborg ofborg bot requested a review from costrouc June 20, 2020 20:01
@gloaming
Copy link
Contributor

LGTM

https://github.com/NixOS/nixpkgs/pull/91180
6 package failed to build:
ape python37Packages.nvchecker python37Packages.sunpy python38Packages.nvchecker python38Packages.sunpy qutebrowser

21 package were built:
lexicon python27Packages.influxdb python27Packages.requests-file python27Packages.tldextract python37Packages.aioftp python37Packages.graphite_api python37Packages.influxdb python37Packages.influxgraph python37Packages.parfive python37Packages.requests-file python37Packages.structlog python37Packages.tldextract python38Packages.aioftp python38Packages.graphite_api python38Packages.influxdb python38Packages.influxgraph python38Packages.parfive python38Packages.requests-file python38Packages.structlog python38Packages.tldextract sewer

[nix-shell:~/.cache/nix-review/pr-91180]$ nix run nixpkgs.influxdb
[2 copied (168.6 MiB), 32.7 MiB DL]
[craig@samwise:~/.cache/nix-review/pr-91180]$ influxd &
[...]
[craig@samwise:~/.cache/nix-review/pr-91180]$ python3
Python 3.8.3 (default, May 13 2020, 19:59:26) 
[GCC 9.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import influxdb
>>> c = influxdb.client.InfluxDBClient()
>>> c.ping()
[httpd] ::1 - root [20/Jun/2020:21:37:50 +0100] "GET /ping HTTP/1.1" 204 0 "-" "python-requests/2.23.0" e8837e13-b335-11ea-8002-e0d55ee7fa14 43
'1.8.0'

[nix-shell:~/.cache/nix-review/pr-91180-1]$ lexicon --help
usage: lexicon [-h] [--version] [--delegated DELEGATED] [--config-dir CONFIG_DIR]

@jonringer
Copy link
Contributor Author

doing a few more package cleanups then I'll merge

@ofborg ofborg bot requested a review from smaret June 20, 2020 22:41
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg eval

@jonringer
Copy link
Contributor Author 

https://github.com/NixOS/nixpkgs/pull/91180
5 packages failed to build:
ape python37Packages.nvchecker python37Packages.sunpy python38Packages.nvchecker python38Packages.sunpy

39 packages built:
lexicon python27Packages.requests-file python27Packages.tldextract python37Packages.aioftp python37Packages.aplpy python37Packages.asdf python37Packages.extension-helpers python37Packages.graphite_api python37Packages.influxgraph python37Packages.parfive python37Packages.pyregion python37Packages.pytest-astropy python37Packages.pytest-astropy-header python37Packages.pytest-filter-subpackage python37Packages.radio_beam python37Packages.reproject python37Packages.requests-file python37Packages.spectral-cube python37Packages.structlog python37Packages.tldextract python38Packages.aioftp python38Packages.aplpy python38Packages.asdf python38Packages.extension-helpers python38Packages.graphite_api python38Packages.influxgraph python38Packages.parfive python38Packages.pyregion python38Packages.pytest-astropy python38Packages.pytest-astropy-header python38Packages.pytest-filter-subpackage python38Packages.radio_beam python38Packages.reproject python38Packages.requests-file python38Packages.spectral-cube python38Packages.structlog python38Packages.tldextract qutebrowser sewer

@jonringer jonringer merged commit b5badcf into NixOS:master Jun 22, 2020
@jonringer jonringer deleted the fix-influx branch June 22, 2020 04:57
@jonringer
Copy link
Contributor Author

seeing as almost all of these files were failures previously, I say this is some progress. Other failures can be addressed in other PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@rvl rvl Awaiting requested review from rvl

@costrouc costrouc Awaiting requested review from costrouc

@smaret smaret Awaiting requested review from smaret

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 8.has: documentation 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @gloaming