Revert "Merge nixos-hardware into nixpkgs under /nixos/hardware"
#91165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahamc
requested review from
edolstra,
kalbasit,
Mic92 and
lukateras
as code owners
|
I got an OK to revert on IRC. |
|
WRT license compatibility, nixos-hardware is CC0-1.0, which is public domain dedication with a fallback public license with no license redistribution condition. It can be safely removed in favor of top-level MIT. https://creativecommons.org/publicdomain/zero/1.0/ Agree it should be discussed more. |
Mic92
requested changes
Jun 20, 2020
|
Erm, sorry @Mic92 - your update hadn't appeared before I clicked merge. Let's revert the revert? :) |
|
and discuss there? |
|
Maybe we should do a force push to revert to the state of the repo before the nixos-hardware merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #91160
It isn't cool to merge two separate projects with only one possible hour of discussion. Also, I have questions about license compatibility.