Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: manual: add missing steps to NIXOS_LUSTRATE instructions #91164

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

WIP: manual: add missing steps to NIXOS_LUSTRATE instructions #91164

wants to merge 1 commit into from

Conversation

jacg
Copy link
Contributor

@jacg jacg commented Jun 20, 2020

Motivation for this change

Crucial steps missing from the manual. See #49520.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

My knowledge of this area is very superficial, but I have verified that without the steps outlined in #49520 the lustration process fails (leading to an unbootable system dropping into grub rescue), and that with these steps lustration succeeds.

I have therefore added the aforementioned steps to the manual.

I would welcome help from someone more knowledgeable in this area to:

  • Add commentary to the steps
  • Check whether a more optimal sequence of steps can be found.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-in-distress/3604/29

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Jun 30, 2020 •
edited

I'm not familiar with this process, so I can say these instructions require an explanation on what's going on.

For instance, I would mention to backup and recreate the bootloader, and I would do this by copying with cp -r /boot. I don't understand what simply moving /boot would achive, as everything under /boot/efi would get wiped anyway. Or am I misunderstanding this?

Also, /dev/nvme0n1p1 is the name, specifically, of your disk: this should be made clear or abstracted away from the instruction.

Finally, is this procedure applicable/different under a non-EFI system? This should be mentioned.

@ryantm ryantm marked this pull request as draft October 23, 2020 02:59
@stale
Copy link

stale bot commented Jun 4, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 4, 2021
@obadz obadz mentioned this pull request Dec 23, 2022
Open
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: nixos 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jacg @nixos-discourse @rnhmjoj @wegank