kitty: 0.17.4 -> 0.18.0 #91189
Merged
kitty: 0.17.4 -> 0.18.0 #91189
+19
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
11.by: package-maintainer
|
Looks good to me. Can you squash commits into just one commit? |
teto
reviewed
Jun 21, 2020
teto
reviewed
Jun 21, 2020
teto
approved these changes
Jun 21, 2020
tex
approved these changes
Jun 21, 2020
https://github.com/kovidgoyal/kitty/releases/tag/v0.18.0 I submitted a patch to kitty, so that the library paths can now be passed as arguments to the build system, eliminating the need for patching. This should reduce the required maintenance effort in the future. This commit removes the dependency on `which`, which is no longer necessary since 5e4fe58. It was introduced in 481e61f. The configure phase is now ignored because kitty has no configure script. The kitty tests are now run after compilation. The zsh completions no longer need to be invoked with `source` since 38eb737, so remove the outdated comment. There is now a link to the changelog.
|
I put all the changes into one commit and rebased onto the latest master. |
|
Thanks for merging ❤️. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I submitted a patch to kitty, so that the library paths can now be passed as arguments to the build system, eliminating the need for patching. This should reduce the required maintenance effort in the future.
I removed an outdated comment.
I added a link to the changelog. Where is this link exposed to the user?
I added
dontConfigure = true;to skip the configure phase since kitty has no configure script.I now execute the test suite of kitty. Is the
doCheck = true;attribute needed? It seems to work fine without but I added it anyways.I also removed the dependency
which.Please check that the attributes are ordered in the preferred way.
Motivation for this change
https://github.com/kovidgoyal/kitty/releases/tag/v0.18.0
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)