Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

home-assistant: 0.111.0 -> 0.111.4 #91154

Merged
merged 6 commits into from Jun 21, 2020
Merged

home-assistant: 0.111.0 -> 0.111.4 #91154

merged 6 commits into from Jun 21, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jun 20, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
nixos/home-assistant: make service reloadable
26e9a34 
This allows quick reloads using the following trick:

$(nix-build --show-trace --no-out-link \
  -E '(with import <nixpkgs/nixos> {};
       pkgs.writeScript "update-hass-config"
       config.systemd.services.home-assistant.preStart)')
systemctl reload home-assistant
@Mic92
python3.pkgs.influxdb: fix build
d690aa8
@Mic92
python3.pkgs.pyicloud: fix build
6c1aea6
@Mic92
Copy link
Member Author

Mic92 commented Jun 20, 2020

@GrahamcOfBorg test home-assistant

@ofborg ofborg bot requested review from globin and dotlambda June 20, 2020 10:14
@Mic92 Mic92 force-pushed the homeassistant branch 2 times, most recently from 033ae56 to 8af2ef4 Compare June 20, 2020 11:13
@Mic92
Copy link
Member Author

Mic92 commented Jun 20, 2020

@GrahamcOfBorg test home-assistant

@Mic92
Copy link
Member Author

Mic92 commented Jun 20, 2020

I published an update script as well.

@Mic92
Copy link
Member Author

Mic92 commented Jun 20, 2020

Mhm. That eval issue looks unrelated to mine.

@jonringer
Copy link
Contributor

@GrahamcOfBorg eval

@FRidh
Copy link
Member

FRidh commented Jun 20, 2020 

derivation 'homeassistant-0.111.4' has invalid meta attribute 'tests'

FRidh
FRidh reviewed Jun 20, 2020
View reviewed changes
pkgs/servers/home-assistant/default.nix Outdated
};

meta = with lib; {
homepage = "https://home-assistant.io/";
description = "Open-source home automation platform running on Python 3";
license = licenses.asl20;
maintainers = with maintainers; [ dotlambda globin mic92 ];
tests.nixos = nixosTests.fish;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be in the passthru.

@dotlambda dotlambda linked an issue Jun 21, 2020 that may be closed by this pull request
nixos/home-assistant: test failure #90149
Closed
mweinelt
mweinelt approved these changes Jun 21, 2020
View reviewed changes
Copy link
Member

@mweinelt mweinelt left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deployed and tested. LGTM.

Unrelated nit: The met.no weather component is still not working 😢

@Mic92 Mic92 merged commit 9aa668e into NixOS:master Jun 21, 2020
@Mic92 Mic92 deleted the homeassistant branch June 21, 2020 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh left review comments

@mweinelt mweinelt mweinelt approved these changes

@jonringer jonringer Awaiting requested review from jonringer

@globin globin Awaiting requested review from globin

@dotlambda dotlambda Awaiting requested review from dotlambda

Assignees
No one assigned
Labels
6.topic: nixos 6.topic: python 8.has: module (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nixos/home-assistant: test failure
4 participants
@Mic92 @jonringer @FRidh @mweinelt