Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipfs: 0.5.1 -> 0.6.0 #91135

Merged
merged 1 commit into from Jun 20, 2020
Merged

ipfs: 0.5.1 -> 0.6.0 #91135

merged 1 commit into from Jun 20, 2020

Conversation

Luflosi
Copy link
Contributor

@Luflosi Luflosi commented Jun 20, 2020

Motivation for this change

https://github.com/ipfs/go-ipfs/releases/tag/v0.6.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from fpletz and kalbasit June 20, 2020 00:30
rnhmjoj
rnhmjoj approved these changes Jun 20, 2020
View reviewed changes
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ofBorg says builds and nixosTests.ipfs passes.

@rnhmjoj rnhmjoj merged commit 2fb254c into NixOS:master Jun 20, 2020
@Luflosi Luflosi deleted the update/ipfs branch June 20, 2020 09:36
@Ericson2314
Copy link
Member

The release notes mention some migration in the config? Let's make sure the IPFS NixOS module is not doing anything deprecated?

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Jul 18, 2020

I diffed the config generated by NixOS and the ipfs init one: the only change is they started adding QUIC listen addresses.
We could change the default value of services.ipfs.swamAddresses to include QUIC, but there are no incompatibility, I think.

@Ericson2314
Copy link
Member

Thanks for checking! Let's do that, good to hear there's nothing else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnhmjoj rnhmjoj rnhmjoj approved these changes

@fpletz fpletz Awaiting requested review from fpletz

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Luflosi @Ericson2314 @rnhmjoj