Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

podman: 1.9.3 -> 2.0.1 #91138

Merged
merged 3 commits into from Jun 26, 2020
Merged

podman: 1.9.3 -> 2.0.1 #91138

merged 3 commits into from Jun 26, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Jun 20, 2020 •
edited

https://github.com/containers/libpod/releases/tag/v2.0.0
https://github.com/containers/libpod/releases/tag/v2.0.1

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zowoq
Copy link
Contributor Author

zowoq commented Jun 20, 2020

Can't reproduce this outside the test, seems like an issue with the test environment and not podman, etc.

We might want to merge the containers.conf and automatic subuid/subgid PRs with this, the major version bump seems like a good time to have user config changes.

@zowoq zowoq marked this pull request as ready for review June 23, 2020 22:51
saschagrunert
saschagrunert approved these changes Jun 24, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ofborg ofborg bot requested a review from saschagrunert June 24, 2020 11:46
@zowoq zowoq changed the title podman: 1.9.3 -> 2.0.0 podman: 1.9.3 -> 2.0.1 Jun 25, 2020
@zowoq zowoq mentioned this pull request Jun 25, 2020
Closed
saschagrunert
saschagrunert approved these changes Jun 25, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, thank you for the updated PR. LGTM

@zowoq zowoq merged commit a8efeed into NixOS:master Jun 26, 2020
@zowoq zowoq deleted the podman branch June 26, 2020 02:14
@zowoq
Copy link
Contributor Author

zowoq commented Jun 26, 2020

Upstream has darwin builds again so I'll take a look at fixing that in the next couple of days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam approved these changes

@saschagrunert saschagrunert saschagrunert approved these changes

@adisbladis adisbladis Awaiting requested review from adisbladis

@kalbasit kalbasit Awaiting requested review from kalbasit

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zowoq @marsam @saschagrunert