Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pcloud: Init at 1.8.8 #91182

Merged
merged 1 commit into from Nov 25, 2020
Merged

pcloud: Init at 1.8.8 #91182

merged 1 commit into from Nov 25, 2020

Conversation

Patryk27
Copy link
Member

Motivation for this change

Just a new application: pCloud.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@frondeus
Copy link

Thank you kind sir for your work!

Downloaded, tested and finally pCloud works properly on my nixos laptop ❤️
I tested basic FUSE mounting (by looking at ~/pCloudDrive contents if I can read my cloud drive without allocating gigabytes of disk space), and classic sync capabilities.

I didn't test crypto or sharing tho.

Anyway - thanks.

@Patryk27
Copy link
Member Author

Patryk27 commented Jul 1, 2020

Just reminding; @Mic92 maybe?

@Patryk27
Copy link
Member Author

Ping, ping - maybe @worldofpeace? :-)

@Patryk27 Patryk27 changed the title pcloud: Init at 1.8.4 pcloud: Init at 1.8.8 Nov 1, 2020
@ryantm
Copy link
Member

ryantm commented Nov 1, 2020

Result of nixpkgs-review pr 91182 1

1 package built:
- pcloud

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 91182 run on x86_64-linux 1

1 package built:
  • pcloud

@SuperSandro2000 SuperSandro2000 merged commit 1dde9c5 into NixOS:master Nov 25, 2020
@Patryk27 Patryk27 deleted the pcloud branch November 25, 2020 21:54
@Patryk27 Patryk27 mentioned this pull request Jun 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h cole-h left review comments

@ryantm ryantm ryantm approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Patryk27 @frondeus @ryantm @SuperSandro2000 @cole-h