Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plr: init at 8.4.1 #91155

Merged
merged 1 commit into from Feb 3, 2021
Merged

plr: init at 8.4.1 #91155

merged 1 commit into from Feb 3, 2021

Conversation

qoelet
Copy link
Member

@qoelet qoelet commented Jun 20, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

doronbehar
doronbehar requested changes Dec 16, 2020
View reviewed changes
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to add a line in all-packages.nix.

SuperSandro2000
SuperSandro2000 requested changes Jan 18, 2021
View reviewed changes
pkgs/servers/sql/postgresql/ext/plr.nix Outdated Show resolved Hide resolved
pkgs/servers/sql/postgresql/ext/plr.nix Outdated Show resolved Hide resolved
pkgs/servers/sql/postgresql/ext/plr.nix Outdated Show resolved Hide resolved
pkgs/servers/sql/postgresql/ext/plr.nix Outdated Show resolved Hide resolved
SuperSandro2000
SuperSandro2000 requested changes Jan 31, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the title and commit version number to 8.4 or 8.4.1.

pkgs/servers/sql/postgresql/ext/plr.nix Outdated Show resolved Hide resolved
pkgs/servers/sql/postgresql/ext/plr.nix Outdated Show resolved Hide resolved
pkgs/servers/sql/postgresql/ext/plr.nix Outdated Show resolved Hide resolved
@qoelet qoelet changed the title plr: init at REL8_4 plr: init at REL8_4_1 Feb 1, 2021
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 91155 run on x86_64-linux 1

1 package built:
  • postgresqlPackages.plr (postgresql11Packages.plr)

@SuperSandro2000 SuperSandro2000 changed the title plr: init at REL8_4_1 plr: init at 8.4.1 Feb 2, 2021
@qoelet @SuperSandro2000 @kenny-shen
plr: init at REL8_4_1
87f04c6 
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@SuperSandro2000 SuperSandro2000 merged commit 4760649 into NixOS:master Feb 3, 2021
@qoelet qoelet deleted the plr-init-8.4 branch February 3, 2021 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice thoughtpolice is a code owner

@doronbehar doronbehar Awaiting requested review from doronbehar

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@qoelet @SuperSandro2000 @doronbehar