Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

radicale: 2.1.11 -> 3.0.3 #91168

Merged
merged 3 commits into from Jun 28, 2020
Merged

radicale: 2.1.11 -> 3.0.3 #91168

merged 3 commits into from Jun 28, 2020

Conversation

dotlambda
Copy link
Member

@dotlambda dotlambda commented Jun 20, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dotlambda
Copy link
Member Author

@Valodim This breaks etesync-dav because it is too picky about the radicale version.

@ofborg ofborg bot requested review from pSub, edwtjo, aneeshusa and infinisil June 20, 2020 13:35
dotlambda
dotlambda commented Jun 20, 2020
View reviewed changes
pkgs/top-level/all-packages.nix

radicale = radicale2;
radicale = radicale3;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be moved to aliases.nix?

@dotlambda dotlambda requested review from rycee and andir June 21, 2020 07:51
@dotlambda
Copy link
Member Author

cc @infinisil

@Valodim
Copy link
Contributor

Valodim commented Jun 25, 2020 •
edited

thanks for the heads-up. I think etesync works with radicale3 at this point, too, I'll look into it.

\\ edit

ah, I see it was you who made that commit :) thanks!

@dotlambda dotlambda merged commit 595a3d1 into NixOS:master Jun 28, 2020
@dotlambda dotlambda deleted the radicale-3.0.3 branch June 28, 2020 10:49
@Valodim Valodim mentioned this pull request Jul 20, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pSub pSub Awaiting requested review from pSub

@edwtjo edwtjo Awaiting requested review from edwtjo

@aneeshusa aneeshusa Awaiting requested review from aneeshusa

@infinisil infinisil Awaiting requested review from infinisil

@rycee rycee Awaiting requested review from rycee

@andir andir Awaiting requested review from andir

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@edolstra edolstra Awaiting requested review from edolstra

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@mmahut mmahut Awaiting requested review from mmahut

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees
No one assigned
Labels
6.topic: nixos 8.has: changelog 8.has: documentation 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dotlambda @Valodim