Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apache-kafka: 2.4.0 -> 2.4.1/2.5.0 #91170

Merged
merged 1 commit into from Sep 21, 2020
Merged

apache-kafka: 2.4.0 -> 2.4.1/2.5.0 #91170

merged 1 commit into from Sep 21, 2020

Conversation

DianaOlympos
Copy link
Contributor

Motivation for this change

Update kafka versions

Things done
  • [ x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • [ x] other Linux distributions
  • [ x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [ x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • [ x] Fits CONTRIBUTING.md.

@DianaOlympos
Copy link
Contributor Author

Of note, merging #70207 would helps a loooot with tests....

@ofborg ofborg bot requested a review from ragnard June 20, 2020 13:41
@srhb
Copy link
Contributor

srhb commented Sep 21, 2020

Apologies for the long wait. I'll try to remember to add myself as maintainer when I add 2.6 so I'll notice more quickly. I've tested with a rebase on unstable that 2.4 and 2.5 tests still pass.

As an aside, I agree that some pruning would be very nice here.

@srhb srhb merged commit 44289eb into NixOS:master Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ragnard ragnard Awaiting requested review from ragnard

Assignees
No one assigned
Labels
6.topic: nixos 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DianaOlympos @srhb