Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libgpg-error: Fix cross build #91139

Merged
merged 1 commit into from Jun 20, 2020
Merged

Conversation

Ericson2314
Copy link
Member

Motivation for this change

See comment for details

Fixes #91016

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

See comment for details

Fixes NixOS#91016
@flokli
Copy link
Contributor

flokli commented Jun 20, 2020

Confirmed I can now successfully cross-compile libgpg-error, (and by this, most of cross NixOS). Also verified this is not a mass-rebuild on non-cross.

@Ericson2314, I assume you have tooling, or will file a followup PR for staging?

@flokli flokli merged commit 8276081 into NixOS:master Jun 20, 2020
@Ericson2314 Ericson2314 deleted the libgpg-error-cross branch June 20, 2020 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

libgpg-error fails to cross-compile
3 participants