Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boolector: 3.0.0 -> 3.2.1 #88779

Merged
merged 2 commits into from Jun 8, 2020
Merged

boolector: 3.0.0 -> 3.2.1 #88779

merged 2 commits into from Jun 8, 2020

Conversation

symphorien
Copy link
Member

Motivation for this change

update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/) -> I only tested boolector
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from thoughtpolice May 24, 2020 15:01
thoughtpolice
thoughtpolice approved these changes Jun 5, 2020
View reviewed changes
Copy link
Member

@thoughtpolice thoughtpolice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deeply sorry for the delay here. Two minor nits; if you wouldn't mine addressing them, I'll happily merge this.

pkgs/applications/science/logic/boolector/default.nix Outdated Show resolved Hide resolved
pkgs/applications/science/logic/btor2tools/default.nix Outdated Show resolved Hide resolved
thoughtpolice
thoughtpolice requested changes Jun 5, 2020
View reviewed changes
Copy link
Member

@thoughtpolice thoughtpolice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Whoops, meant to request changes!)

@symphorien
btor2tools: pre55 -> 1.0.0-pre
e91a6d7 
version comes from the VERSION file in the repo
@symphorien
boolector: 3.0.0 -> 3.2.1
76241e9 
enable tests
optionnally enable gmp
@ofborg ofborg bot requested a review from thoughtpolice June 6, 2020 15:40
@thoughtpolice thoughtpolice merged commit 0a48851 into NixOS:master Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice thoughtpolice approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@symphorien @thoughtpolice