Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbreak amazonka-dynamodb #88667

Merged
merged 1 commit into from May 23, 2020

Conversation

markus1189
Copy link
Contributor

Motivation for this change

amazonka-dynamodb is marked as broken, but compiles fine for me.

Things done

Ran

nix build -f channel:nixpkgs-unstable --no-link haskellPackages.amazonka-dynamodb --arg config '{allowBroken = true;}'

The above command finishes compilation without errors.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cdepillabout
Copy link
Member

Thanks, compiles for me. Merging in!

In the future, please create the commit messages according to the rules here: https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md

@cdepillabout cdepillabout merged commit 05daa18 into NixOS:haskell-updates May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants