Skip to content

relax PullRequestAction parsing #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2020
Merged

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented May 23, 2020

Unknown events are fine here, as long as it's a valid event continue and
consider it not interesting instead.

Should alleviate fixes like #496 in the future.

Verified

This commit was signed with the committer’s verified signature.
edolstra Eelco Dolstra
Unknown events are fine here, as long as it's a valid event continue and
consider it not interesting instead.

Should alleviate fixes like NixOS#496 in the future.
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for dropping the other variants? Is it because they are currently unused?

@LnL7
Copy link
Member Author

LnL7 commented May 23, 2020

Yeah they where there for the same reason as ConvertToDraft, if we ever want to use specific actions they can be added back. For example with skipping builds for draft pull requests making the pr as ready should trigger builds.

@LnL7 LnL7 merged commit d9dccbc into NixOS:released May 23, 2020
@LnL7 LnL7 deleted the relax-ghevent-parsing branch May 23, 2020 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants