Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clipit: enable appindicator support #88786

Merged
merged 1 commit into from Nov 27, 2020
Merged

clipit: enable appindicator support #88786

merged 1 commit into from Nov 27, 2020

Conversation

NickHu
Copy link
Contributor

@NickHu NickHu commented May 24, 2020

Motivation for this change

Makes libayatana-appindicator available to clipit. This pull request depends on #88783.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@NickHu NickHu mentioned this pull request May 24, 2020
Closed
@NickHu NickHu marked this pull request as ready for review October 13, 2020 15:08
@ofborg ofborg bot requested a review from kamilchm October 13, 2020 15:19
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 88786 run on x86_64-linux 1

1 package built:
  • clipit

@SuperSandro2000 SuperSandro2000 merged commit 1f5bd20 into NixOS:master Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilchm kamilchm kamilchm approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NickHu @SuperSandro2000 @kamilchm