Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parcellite: enable appindicator support #88785

Merged
merged 1 commit into from Feb 3, 2023
Merged

parcellite: enable appindicator support #88785

merged 1 commit into from Feb 3, 2023

Conversation

NickHu
Copy link
Contributor

@NickHu NickHu commented May 24, 2020

Motivation for this change

Make libappinidcator available to parcellite

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@NickHu NickHu mentioned this pull request May 24, 2020
Closed
@NickHu NickHu requested a review from cole-h May 27, 2020 13:07
@NickHu
Copy link
Contributor Author

NickHu commented May 27, 2020

Even when building with this, and parcellite advertises AppIndicator support, I'm not actually able to get it to work...

@stale
Copy link

stale bot commented Nov 23, 2020

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 23, 2020
@SuperSandro2000 SuperSandro2000 marked this pull request as draft January 18, 2021 18:33
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 18, 2021
@stale
Copy link

stale bot commented Jul 21, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 21, 2021
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Feb 3, 2023
@Artturin Artturin marked this pull request as ready for review February 3, 2023 13:30
@Artturin Artturin merged commit 70bb20b into NixOS:master Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h Awaiting requested review from cole-h

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NickHu @SuperSandro2000 @Artturin