Add typing extensions as an explicit dependency #1351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adisbladis
force-pushed
the
typing_ext_dep
branch
from
b307fa0
to
db39840
Compare
cole-h
approved these changes
May 24, 2020
There was a problem hiding this comment.
This lets me run from master by crafting an overlay like the following:
nixops2 = (callPackage
(fetchTarball "https://github.com/adisbladis/nixops/archive/typing_ext_dep.tar.gz") { }
).overrideAttrs ({ ... }: {
preBuild = ''substituteInPlace nixops/__main__.py --replace "@version@" "2.0-pre"'';
});Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's imported at runtime so it should be listed as a dependency in
pyproject.toml.