Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deno: 1.0.0 -> 1.0.5 #88681

Merged
merged 3 commits into from Jun 12, 2020
Merged

deno: 1.0.0 -> 1.0.5 #88681

merged 3 commits into from Jun 12, 2020

Conversation

06kellyjac
Copy link
Member

@06kellyjac 06kellyjac commented May 23, 2020 •
edited

Motivation for this change

deno 1.0.5 released

Things done

Bumped version, sha, and cargo sha

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@06kellyjac 06kellyjac force-pushed the deno_1.0.2 branch 3 times, most recently from 07c56fa to 1b34a8c Compare May 24, 2020 19:15
@marsam
Copy link
Contributor

marsam commented May 24, 2020

@GrahamcOfBorg build deno

@06kellyjac
Copy link
Member Author

Hmmm there seems to be a range of different tests failing for the different build targets.

I'll do some digging tomorrow

@06kellyjac 06kellyjac marked this pull request as draft May 26, 2020 08:03
@06kellyjac 06kellyjac force-pushed the deno_1.0.2 branch 3 times, most recently from 1f6e30e to 1b34a8c Compare May 26, 2020 09:25
@06kellyjac
Copy link
Member Author

@marsam I'm really not too sure why the tests fail this way.
They're meant to be running an integration test (for the most commonly failing test type) e.g. "deno_test_fail_fast" which correctly compares it's output to "deno_test_fail_fast.out" but the output is from "deno_test" so it fails
I've had cases where I run the exact same nix & the tests build and pass the 2nd time so (IMO) it's highly likely there's something wrong with the deno tests & because of this temperamental nature of the issue it's a nightmare to reproduce.

This is the block of code responsible for the most failures:
https://github.com/denoland/deno/blob/master/cli/tests/integration_tests.rs#L2837-L2906

In one of my PRs I'm adding some logging for args and test_dir to help with the debugging:
https://github.com/denoland/deno/blob/master/cli/tests/integration_tests.rs#L2854-L2855
But if it's some kind of weird parallel stdout thingie where stdout from one test endup in another it wont help much.
Also it's supprising this kind of collision style issue doesn't show up more regularly in their CI. Maybe the CI is just running less parallel threads???

I like the tests running because it's fun & helps check for f-ups etc but should we turn the checks off for now until we get a handle on this?
Would love to hear your thoughts

@06kellyjac 06kellyjac changed the title deno: 1.0.0 -> 1.0.2 deno: 1.0.0 -> 1.0.3 Jun 2, 2020
@06kellyjac 06kellyjac force-pushed the deno_1.0.2 branch 2 times, most recently from 8ccf694 to f3c44a7 Compare June 3, 2020 20:27
@06kellyjac 06kellyjac changed the title deno: 1.0.0 -> 1.0.3 deno: 1.0.0 -> 1.0.5 Jun 3, 2020
@06kellyjac 06kellyjac force-pushed the deno_1.0.2 branch 4 times, most recently from 8c895f7 to b347752 Compare June 6, 2020 14:43
@06kellyjac
Copy link
Member Author

I've decided to abandon the tests for now. Once there's more logging in the upstream tests I'll give it another crack.

Also added an upgrade script that does most tasks in parallel.
I know it's pretty uncommon but I'll be the one to maintain it, if I stop maintaining this I'll convert it to bash first (similar to nym/update.sh)

@06kellyjac
deno: 1.0.0 -> 1.0.5
b94b0e4 
Dropped tests as they were running inconsistently.
Removed python as if the rusty_v8 lib is present no python is ran.
Will be happy to add them back in once resolved.
@06kellyjac
deno: refactor ready for an updateScript
6c03b04 
Refactored the structure of the package to be easier to auto update
@06kellyjac
deno: add updateScript for automatic updates
55da692 
This'll save time and avoid human error.
Wrote in deno typescript because why not.
@06kellyjac
Copy link
Member Author

Also removed python as it's not actually required when we're pre-fetching the rusty_v8 library

@06kellyjac 06kellyjac marked this pull request as ready for review June 6, 2020 15:28
@marsam marsam merged commit 9b42c85 into NixOS:master Jun 12, 2020
@marsam
Copy link
Contributor

marsam commented Jun 12, 2020

Thank you for working on this, and sorry for the delay

This is the block of code responsible for the most failures

I think you can add a patch deleting the offending tests

@06kellyjac 06kellyjac deleted the deno_1.0.2 branch June 12, 2020 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@06kellyjac @marsam