Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lieer: 1.1 -> 1.2 #88683

Merged
merged 2 commits into from May 24, 2020
Merged

lieer: 1.1 -> 1.2 #88683

merged 2 commits into from May 24, 2020

Conversation

flokli
Copy link
Contributor

@flokli flokli commented May 23, 2020 •
edited

Motivation for this change

gmi send supporting -t, thus being compatible with neomutt (gauteh/lieer#154)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli flokli requested review from kirelagin and KaiHa May 23, 2020 12:34
@flokli
Copy link
Contributor Author

flokli commented May 24, 2020

Updated to fetch the sources from PyPI, as they're published now too (gauteh/lieer#138 (comment)).

@kirelagin, can you take a look?

@kirelagin
Copy link
Member

I once tried to add a new Python package, and someone suggested that I use GitLab instead of PyPi. I’m not sure what the policy in nixpkgs currently is, but the argument that the source repository is usually more up-to-date than PyPi sounds justified...

@flokli
Copy link
Contributor Author

flokli commented May 24, 2020

We prefer to fetch from git when tests are missing from the PyPI releases, but usually, PyPI is the more canonical location.

As lieer doesn't have tests, we don't need to worry about missing tests 🙈

gauteh/lieer#138 reads like PyPI should soon be always up to date on releases, but I'll ask back.

@flokli
Copy link
Contributor Author

flokli commented May 24, 2020

Let's merge this in fetching from PyPI for now, we can always flip it back to GitHub, if it turns out to be better there ;-)

@flokli flokli merged commit 34b3933 into NixOS:master May 24, 2020
@flokli flokli deleted the lieer-1.2 branch May 24, 2020 15:50
@flokli
Copy link
Contributor Author

flokli commented May 24, 2020

moved back to fetchFromGitHub in 2226972.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirelagin kirelagin kirelagin approved these changes

@KaiHa KaiHa Awaiting requested review from KaiHa

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@flokli @kirelagin