Remove ImageBitmap's colorSpaceConversion srgb/p3/rec2020 options #23745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 23, 2020
There exist standard colorSpaceConversion options of none (ignore color space) and default (use color space). Specifying srgb, p3, or rec2020 here is not appropriate. A more appropriate place would be in ImageData (where there do exist canvas color space parameters). Bug: 1083693 Change-Id: I3741454c36a59b3c8d679ec843aa05cebcc9d9c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213777 Reviewed-by: Fernando Serboncini <fserb@chromium.org> Reviewed-by: ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#771609}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2213777
branch
from
79bf48c
to
c6ffe5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There exist standard colorSpaceConversion options of none (ignore
color space) and default (use color space). Specifying srgb, p3, or
rec2020 here is not appropriate. A more appropriate place would
be in ImageData (where there do exist canvas color space parameters).
Bug: 1083693
Change-Id: I3741454c36a59b3c8d679ec843aa05cebcc9d9c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213777
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771609}