Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wesnoth: 1.14.11 -> 1.14.12 #88788

Merged
merged 1 commit into from Jun 17, 2020
Merged

wesnoth: 1.14.11 -> 1.14.12 #88788

merged 1 commit into from Jun 17, 2020

Conversation

kampka
Copy link
Contributor

@kampka kampka commented May 24, 2020

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kampka
Copy link
Contributor Author

kampka commented May 24, 2020

@GrahamcOfBorg build wesnoth

@ofborg ofborg bot requested a review from abbradar May 24, 2020 16:24
@marsam marsam mentioned this pull request May 24, 2020
Closed
puzzlewolf
puzzlewolf suggested changes May 24, 2020
View reviewed changes
Copy link
Contributor

@puzzlewolf puzzlewolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for moving to the github source. I just found one thing :)

This PR replaces #88777 (automatic update).

pkgs/games/wesnoth/default.nix Outdated Show resolved Hide resolved
@puzzlewolf
Copy link
Contributor

Can you move the meta.homepage from http to https, too?

@kampka
Copy link
Contributor Author

kampka commented May 24, 2020

Can you move the meta.homepage from http to https, too?

Done

puzzlewolf
puzzlewolf approved these changes May 24, 2020
View reviewed changes
Copy link
Contributor

@puzzlewolf puzzlewolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Both binaries start, played a bit of the tutorial :)

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/187

@teto teto merged commit eb296c5 into NixOS:master Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puzzlewolf puzzlewolf puzzlewolf approved these changes

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kampka @puzzlewolf @nixos-discourse @teto