Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

services.x11.videoDrivers: Don't include vmware driver on non-x86 platforms #88718

Merged
merged 1 commit into from Jun 11, 2020
Merged

services.x11.videoDrivers: Don't include vmware driver on non-x86 platforms #88718

merged 1 commit into from Jun 11, 2020

Conversation

adisbladis
Copy link
Member

@adisbladis adisbladis commented May 23, 2020 •
edited

Motivation for this change

This driver is x86 only.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@adisbladis adisbladis force-pushed the vmware-xorg-driver-defaults branch 2 times, most recently from 4f6f797 to d963996 Compare May 24, 2020 14:25
@adisbladis
Copy link
Member Author

I've opted to simply remove vmware from the default drivers, there is a vmware guest module that sets this driver and it doesn't make sense to have it in the defaults list.

flokli
flokli requested changes May 24, 2020
View reviewed changes
Copy link
Contributor

@flokli flokli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an entry to the release notes mentioning this and directing people to set options.virtualisation.vmware.guest.enable = true, so we don't drop this silently.

@adisbladis adisbladis force-pushed the vmware-xorg-driver-defaults branch 2 times, most recently from 49cffe3 to 3f97a5b Compare June 11, 2020 16:27
@adisbladis
services.x11.videoDrivers: Don't include vmware driver by default
1a5dafc 
A better option for vmware guests is to set `virtualisation.vmware.guest.enable`.
@adisbladis adisbladis merged commit a5a52e8 into NixOS:master Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor left review comments

@flokli flokli flokli requested changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: changelog 8.has: documentation 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adisbladis @bjornfor @flokli