Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnomeExtensions.no-title-bar: unbreak, 9 -> 2020-05-14 #88679

Closed
wants to merge 1 commit into from
Closed

gnomeExtensions.no-title-bar: unbreak, 9 -> 2020-05-14 #88679

wants to merge 1 commit into from

Conversation

amaxine
Copy link
Member

@amaxine amaxine commented May 23, 2020

Motivation for this change

Version in nix has been unmaintained but a fork has had updates for the last two gnome versions - could be backported to 20.03 as well to unbreak there - I've been using it since January and it works fine.

No tags upstream so switched to a revision and changed version to a date. Not sure if I've gone the right way about all of the things in the nixpkg though.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@amaxine
gnomeExtensions.no-title-bar: unbreak
1557563 
9 -> 2020-05-14
Switches to a supported fork, updates patches as necessary
@ofborg ofborg bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label May 23, 2020
@ofborg ofborg bot requested a review from jonafato May 23, 2020 12:16
endocrimes
endocrimes approved these changes May 23, 2020
View reviewed changes
Copy link
Member

@endocrimes endocrimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bjornfor
Copy link
Contributor

I'd be nice to ask upstream to make a release. (I personally don't like packaging unreleased software.)

@worldofpeace worldofpeace requested a review from a team June 18, 2020 00:02
@amaxine amaxine closed this Aug 12, 2020
@justinas
Copy link
Contributor

@maxeaubrey sad to see this closed 😟 any plans to try and unbreak this still?

@amaxine
Copy link
Member Author

amaxine commented Aug 13, 2020

@justinas If upstream starts tagging releases I'll reopen this/open a new PR. Otherwise it works as is.

@amaxine amaxine deleted the no-title-bar_unbreak branch September 10, 2020 08:47
@amaxine amaxine mentioned this pull request Dec 13, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@endocrimes endocrimes endocrimes approved these changes

@jonafato jonafato Awaiting requested review from jonafato

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@amaxine @bjornfor @justinas @endocrimes