Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guile setup hook, use compiled files #88720

Merged
merged 1 commit into from Dec 2, 2020
Merged

Guile setup hook, use compiled files #88720

merged 1 commit into from Dec 2, 2020

Conversation

KoviRobi
Copy link
Contributor

Often packages install the compiled files to
$(libdir)/guile/$(GUILE_EFFECTIVE_VERSION)/ccache (e.g. see
guile-opengl). This path is not explicitly given in the info page, but
is used in a couple of places, and is also part of %load-compiled-path
variable in guile (for "${guile}/lib/guile/2.2/ccache).

Similarly, the site-ccache is also part of %load-compiled-path in
guile.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@KoviRobi KoviRobi mentioned this pull request May 23, 2020
Draft
10 tasks
@KoviRobi
Copy link
Contributor Author

Something to investigate is why does everything in GUILE_LOAD_COMPILED_PATH there twice

@FRidh FRidh added this to WIP in Staging via automation Jun 4, 2020
@FRidh FRidh moved this from WIP to Needs review in Staging Sep 4, 2020
@stale
Copy link

stale bot commented Nov 20, 2020

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 20, 2020
@SuperSandro2000
Copy link
Member

Can you target staging and rebase the PR?

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 23, 2020
AluisioASG added a commit to AluisioASG/nixexprs that referenced this pull request Nov 25, 2020
@AluisioASG
Try a new approach to setting Guile load paths
1e26dfb 
Don't touch the install paths, but let Guile's setup hook do the right
think[^1].  Also run `haunt --version` after installing to make sure we
got this right.

[^1]: Which it somewhat doesn't; see github:NixOS/nixpkgs#88720.
@andir
guile: setup hook, use compiled files
612ec25 
Often packages install the compiled files to
`$(libdir)/guile/$(GUILE_EFFECTIVE_VERSION)/ccache` (e.g. see
guile-opengl). This path is not explicitly given in the info page, but
is used in a couple of places, and is also part of `%load-compiled-path`
variable in guile (for `"${guile}/lib/guile/2.2/ccache`).

Similarly, the site-ccache is also part of `%load-compiled-path` in
guile.
@andir andir changed the base branch from master to staging November 28, 2020 10:17
@andir
Copy link
Member

andir commented Nov 28, 2020

I rebased this onto staging and fixed the commit message to be in line with our contribution guidelines.

@KoviRobi
Copy link
Contributor Author

KoviRobi commented Dec 2, 2020

Thanks @andir (I didn't realise others could force-push to my branch, I presume because it's forked from NixOS/nixpkgs and it's a pull request).

For what it's worth, the duplicate paths are a problem elsewhere so this pull request doesn't create any new problems. E.g.

[[ rmk35@pc-nixos-a... /pkgs/unstable ]]|$ nix-shell -p pyrex

[nix-shell:~/programming/nix/pkgs/unstable]$ echo $PYTHONPATH | tr : \\n
/nix/store/vlijrzyfhzl7s08296fjy42cn0kj50pw-python2.7-pyrex-0.9.5.1.1/lib/python2.7/site-packages
/nix/store/vfd4wghhzz4afzxgwynsnbj9xzpkib4z-python-2.7.18/lib/python2.7/site-packages
/nix/store/vlijrzyfhzl7s08296fjy42cn0kj50pw-python2.7-pyrex-0.9.5.1.1/lib/python2.7/site-packages
/nix/store/vfd4wghhzz4afzxgwynsnbj9xzpkib4z-python-2.7.18/lib/python2.7/site-packages

I don't know why this is but I suspect it's because of dependency graph walking and shared dependencies.

@andir andir merged commit 81b2a9c into NixOS:staging Dec 2, 2020
Staging automation moved this from Needs review to Done Dec 2, 2020
@andir
Copy link
Member

andir commented Dec 2, 2020

Sounds good enough for now. This is already an improvement. When we find a "better" way of doing that we can do it.

@KoviRobi KoviRobi deleted the guile-compiled-path branch December 2, 2020 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KoviRobi @SuperSandro2000 @andir