Remove messy device.info option
#152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of borrowing some of its system.build products, rely instead on a full system.build for the recovery.img. This allows us to better make use of the implicit declarativeness of the system configuration. At some point the recovery "system" will be moved out of that file and things will continue to work.
This is the first step in actually dropping all device information.
samueldr
changed the title
device.info optiondevice.info option
samueldr
force-pushed
the
fix/kernel-cmdline
branch
2 times, most recently
from
e61ac27
to
12913af
Compare
(and fix device_info.arch)
The last option will be cleaned up last.
The depthcharge build doesn't rely on the freeform option anymore.
We cannot use a "linuxPackagesFor" attrset due to older OEM kernels.
samueldr
force-pushed
the
fix/kernel-cmdline
branch
from
12913af
to
adc157f
Compare
samueldr
changed the title
device.info optiondevice.info option
|
I don't think it's strictly required, but it would be nice to have confirmation that it didn't break those devices I don't own.
It's not a no-op, but functionally, it should end up being the same. (Inputs change a bit, but not in a significant manner.) |
|
Seems to be working for me. I built a I had to use an older nixpkgs since the latest one seems to have an issue with systemd while cross compiling on |
|
Last I checked, xiaomi-tissot wasn't working at all, and I haven't had the time to look into it yet unfortunately. Will have to check it out again sometime soon. |
This was referenced May 25, 2020
samueldr
added a commit
to samueldr-wip/mobile-nixos-wip
that referenced
this pull request
May 26, 2020
samueldr
added a commit
that referenced
this pull request
May 26, 2020
bin/menuconfig: Fix breakage caused by #152
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather, remove unused options, and then add proper options or use existing NixOS options.
This gives us working
boot.kernelParamssupport for stage-1 builds. Configuration can now add and remove to the kernel parameters.This also reduces the risks of doing something wrong with the untyped mess of options that was present previously.