Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixosTests.nextcloud: Add davfs2 example to the VM test #88721

Merged
merged 1 commit into from May 23, 2020
Merged

nixosTests.nextcloud: Add davfs2 example to the VM test #88721

merged 1 commit into from May 23, 2020

Conversation

flokli
Copy link
Contributor

@flokli flokli commented May 23, 2020

Some people use davfs2 to mount a NextCloud instance, so make sure this
works as well.

The /tmp/davfs2-secrets file needs to be created via an activation script, as mount.davfs2 doesn't like it to that file world-readable (which it is if it comes from the nix store).

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli flokli requested a review from Ma27 May 23, 2020 22:04
Ma27
Ma27 approved these changes May 23, 2020
View reviewed changes
nixos/tests/nextcloud/basic.nix Outdated Show resolved Hide resolved
@flokli flokli force-pushed the nixostests-nextcloud-davfs2 branch from ae5ed5a to 0aac5e7 Compare May 23, 2020 23:00
@flokli
nixosTests.nextcloud: Add davfs2 example to the VM test
75e18ab 
Some people use davfs2 to mount a NextCloud instance, so make sure this
works as well.
@flokli flokli force-pushed the nixostests-nextcloud-davfs2 branch from 0aac5e7 to 75e18ab Compare May 23, 2020 23:08
@flokli
Copy link
Contributor Author

flokli commented May 23, 2020

In fact, we can also skip the _netdev option, as systemd-fstab-generator knows davfs mounts are networked. Sweet :-)

@Ma27 Ma27 merged commit 946f7d1 into NixOS:master May 23, 2020
@flokli flokli deleted the nixostests-nextcloud-davfs2 branch May 24, 2020 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@flokli @Ma27