Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/networkmanager: apply --filter-policy=STRICT to modemmanager service #88725

Merged
merged 1 commit into from May 24, 2020
Merged

nixos/networkmanager: apply --filter-policy=STRICT to modemmanager service #88725

merged 1 commit into from May 24, 2020

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented May 23, 2020 •
edited

Motivation for this change

#88089
https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/blob/1.8.0/NEWS#L28

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli flokli merged commit 73b4ea1 into NixOS:master May 24, 2020
@aanderse aanderse deleted the modem-manager branch May 24, 2020 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli flokli approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aanderse @flokli