-
Notifications
You must be signed in to change notification settings - Fork 12
Top of tree build is broken #10
Comments
https://developer.gnome.org/gtkmm/stable/classGtk_1_1Grid.html#a664d8700c0a8176c2e2595e1d9938ff0 That looks like a valid call that uses the default arguments, and it builds fine for me on gtkmm 3.24.0 (Debian Buster). What version are you trying to build against? If you change the attach() call to explicitly specify the width/height arguments, so attach(m_scopeNameLabel, 0, 0, 1, 1), does it build OK? It's possible older GTK versions didn't have the default values. |
I'm on Ubuntu 18.4, which seems to have gtkmm version 3.22.2.
Yes, it gets past this issue this way. After that, the remaining errors are as follows:
Let me see if I can fix those myself... Tom |
I don't have a clone repo, but here's a patch file that allows me to compile on my machine. I haven't tested it because I'm not (yet) able to connect to my scope. Tom |
So it looks like the default arguments to attach_next_to and attach aren't present in 3.22? Let me test on my end... |
Yes. This is what I see in my void attach(Widget& child, int left, int top, int width, int height);
..
void attach_next_to(Widget& child, Widget& sibling, PositionType side, int width, int height); No default parameters to be seen. |
I'm actually about to update another dialog to use Gtk::Grid (related ngscopeclient/scopehal-apps#104). In a few hours when I'm done, can you make a fork with your fixes and test? I'll send you some test waveforms you can use for offline dev/testing until your scope is able to connect. What make/model are you trying to use? |
I'm using a Siglent SDS 2304X. Some Siglents use standard sockets (which is already supported) but a bunch of others use VXI11 and don't support the standard sockets. This is badly documented and thus a major waste of time. ("Why are these sockets not working???") I'm almost done with SCPILxiTransport, which should add support for those VXI11 ones. |
My git skills with submodules are severely lacking. But I'll try. |
Try 1b14685 and see if it fixed your problem? |
Compiles fine! Closing. |
I can build fine with commit 1d22516.
With commit e090e4a, I get:
Tom
The text was updated successfully, but these errors were encountered: