Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-backgrounds] border-radius-clipping test has issues #23748

Closed
TalbotG opened this issue May 24, 2020 · 1 comment
Closed

[css-backgrounds] border-radius-clipping test has issues #23748

TalbotG opened this issue May 24, 2020 · 1 comment

Comments

@TalbotG
Copy link
Contributor

TalbotG commented May 24, 2020

zhouli ,

I hope you will read this (I will send you an email in a few min.).

Right now,
border-radius-clipping.html test
has several issues:

  • border-radius-clipping.html is currently failed by all browsers
  • in the test, there is in fact 2 sub-tests
  • the #dummy related sub-test generates horizontal and vertical scroll bars which are not present in the reference file
  • the tiny blue border is not the target of the test itself (and not part of the test itself) but, once curved, it can generate differences detected by screen shot comparison
  • the assert text says should clip but it must say must clip instead
  • a meta charset is missing in the test

I propose
http://www.gtalbot.org/BrowserBugsSection/CSS3Backgrounds/border-radius-clipping-GT.html
and
http://www.gtalbot.org/BrowserBugsSection/CSS3Backgrounds/border-radius-clipping-002-GT.html
to rehabilitate your current test with these 2 replacement tests.
The correspondent reference files are:
http://www.gtalbot.org/BrowserBugsSection/CSS3Backgrounds/reference/border-radius-clipping-ref.html
and
http://www.gtalbot.org/BrowserBugsSection/CSS3Backgrounds/reference/ref-nothing-below.xht

zhouli, if you read this, I propose we co-author these 2 new tests and replace your current test.

@TalbotG
Copy link
Contributor Author

TalbotG commented Jul 16, 2020

#23880
has been approved and has been merged. Therefore, I am closing this issue here.

@TalbotG TalbotG closed this as completed Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant