Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transmission: 2.94 -> 3.00 #88701

Merged
merged 1 commit into from May 24, 2020
Merged

transmission: 2.94 -> 3.00 #88701

merged 1 commit into from May 24, 2020

Conversation

adisbladis
Copy link
Member

@adisbladis adisbladis commented May 23, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from astsmtl, wizeman and vcunat May 23, 2020 18:50
tomberek
tomberek approved these changes May 23, 2020
View reviewed changes
Copy link
Contributor

@tomberek tomberek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds, runs, and functions as expected on NixOS. Did not test OSX.

vcunat
vcunat approved these changes May 24, 2020
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no issues so far.

@adisbladis adisbladis merged commit 37cdb3c into NixOS:master May 24, 2020
@diamondburned
Copy link

diamondburned commented Jun 1, 2020 •
edited

This commit made Transmission fail to detect all of my old torrents. I will try and roll it back with some override jankery.

Edit: They didn't come back.

@vcunat
Copy link
Member

vcunat commented Jun 1, 2020

Hmm, the new version does migrate the *.torrent files to a new naming scheme, but that worked for me without a problem. Perhaps it would be best to discuss your case with upstream.

@anna328p
Copy link
Member

anna328p commented Jun 6, 2020 •
edited

This deleted all of my torrent files!!

@vcunat vcunat mentioned this pull request Jun 18, 2020
Closed
1 task
@vcunat
Copy link
Member

vcunat commented Jun 24, 2020 •
edited

Could you two be running into this issue? transmission/transmission#1325

In any case those problems will probably be best taken upstream (like that link above). I hope they will be rare enough.

@anna328p
Copy link
Member

Could you two be running into this issue? transmission/transmission#1325

In any case those problems will probably be best taken upstream (like that link above). I hope they will be rare enough.

No. The torrent files were just deleted; the directory was completely empty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h cole-h left review comments

@tomberek tomberek tomberek approved these changes

@vcunat vcunat vcunat approved these changes

@astsmtl astsmtl Awaiting requested review from astsmtl

@wizeman wizeman Awaiting requested review from wizeman

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@adisbladis @diamondburned @vcunat @anna328p @tomberek @cole-h