Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dotnetCorePackages: Add support for Darwin #88750

Merged
merged 1 commit into from May 27, 2020
Merged

dotnetCorePackages: Add support for Darwin #88750

merged 1 commit into from May 27, 2020

Conversation

moinessim
Copy link
Contributor

Motivation for this change

Having dotnet in nixpkgs for Drawin would be great, and the following PR was conflicting.
#78787

Things done

Added hash for Darwin versions.
Parametrized platform in download urls.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 8.has: package (new) labels May 24, 2020
@ofborg ofborg bot requested a review from kuznero May 24, 2020 06:27
@veprbl veprbl requested a review from jonringer May 25, 2020 19:46
@jonringer
Copy link
Contributor

Thank you @moinessim for opening your first pr :)

@jonringer
Copy link
Contributor

@GrahamcOfBorg build dotnetCorePackages.sdk_2_1
@GrahamcOfBorg build dotnetCorePackages.sdk_2_2
@GrahamcOfBorg build dotnetCorePackages.sdk_3_0
@GrahamcOfBorg build dotnetCorePackages.sdk_3_1

jonringer
jonringer approved these changes May 27, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

we should probably create a script to update this

@jonringer jonringer merged commit 1c8f4ec into NixOS:master May 27, 2020
This was referenced May 29, 2020
Closed
Closed
@jonringer jonringer mentioned this pull request Aug 19, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@kuznero kuznero Awaiting requested review from kuznero

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@moinessim @jonringer @Janik-Haag