Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.pyspice: init at 1.4.3 #88688

Merged
merged 1 commit into from Sep 20, 2020
Merged

python3Packages.pyspice: init at 1.4.3 #88688

merged 1 commit into from Sep 20, 2020

Conversation

matthuszagh
Copy link
Contributor

@matthuszagh matthuszagh commented May 23, 2020 •
edited

Motivation for this change

Adds PySpice. I tested this on some of the examples in the doc and everything worked.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh FRidh self-assigned this May 23, 2020
@FRidh
Copy link
Member

FRidh commented May 23, 2020

pyyaml and requests bumps need to be tested with a hydra job, so this PR is going to take some time.

@ofborg ofborg bot requested a review from dotlambda May 23, 2020 13:43
FRidh
FRidh reviewed Jun 13, 2020
View reviewed changes
pkgs/development/python-modules/pyspice/default.nix Outdated
pythonImportsCheck = [ "PySpice" ];

postPatch = ''
substituteInPlace PySpice/Spice/NgSpice/Shared.py --replace "ffi.dlopen(self.library_path)" "ffi.dlopen('${libngspice}/lib/libngspice.so')"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use stdenv.hostPlatform.extensions.sharedLibrary instead of .so

@FRidh
Copy link
Member

FRidh commented Jun 13, 2020

pyyaml and requests are now in staging. Probably land in master in a week or so.

@matthuszagh
Copy link
Contributor Author

Great, thanks for the update. I've also implemented the change. Let me know if any issues.

@jonringer
Copy link
Contributor

commit message should be:

python3Packages.pyspice: init at 1.4.2

@matthuszagh
Copy link
Contributor Author

Done.

@matthuszagh
Copy link
Contributor Author

@FRidh any chance of an update on this? Thanks!

@matthuszagh matthuszagh requested a review from FRidh August 8, 2020 22:30
@marsam marsam changed the title Pyspice python3Packages.pyspice: init at 1.4.3 Sep 20, 2020
@marsam marsam merged commit 6aad47c into NixOS:master Sep 20, 2020
@matthuszagh matthuszagh deleted the pyspice branch September 20, 2020 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda Awaiting requested review from dotlambda

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees

@FRidh FRidh

Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@matthuszagh @FRidh @jonringer @marsam