Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lnch: init at 2017-02-16 #88694

Merged
merged 1 commit into from May 23, 2020
Merged

lnch: init at 2017-02-16 #88694

merged 1 commit into from May 23, 2020

Conversation

AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented May 23, 2020

Motivation for this change

lnch is a small go app that launches a process and moves it out of the process
group. It is useful to some scripts that need to launch a process without
killing the previous one, like custom script app launchers for lightweight
window managers.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

lnch is a small go app that launches a process and moves it out of the process
group. It is useful to some scripts that need to launch a process without
killing the previous one, like custom script app launchers for lightweight
window managers.
};

meta = with stdenv.lib; {
homepage = "https://github.com/mitchellh/gox";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong homepage?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I will fix it :/

homepage = "https://github.com/mitchellh/gox";
description = "A small go app that launches a process and moves it out of the process group";
platforms = platforms.all;
license = licenses.publicDomain; # really I don't know
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the absence of a license places it in the public domain.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will try to contact the upstream

@orivej
Copy link
Contributor

orivej commented May 23, 2020

I do not quiet understand your use case but it seems that the standard setsid utility would fulfill it too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants