New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sigal: 2.0 -> 2.1 #88759
sigal: 2.0 -> 2.1 #88759
Conversation
@matthiasbeyer Can you update the PR? |
pkgs/top-level/all-packages.nix
Outdated
@@ -6605,7 +6605,9 @@ in | |||
|
|||
sieve-connect = callPackage ../applications/networking/sieve-connect {}; | |||
|
|||
sigal = callPackage ../applications/misc/sigal { }; | |||
sigal = callPackage ../applications/misc/sigal { | |||
inherit (python.passthru) pythonAtLeast; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for this line now. Also, can you squash the commits already?
6597b6f
to
d4ed37b
Compare
@@ -1,14 +1,16 @@ | |||
{ lib, python3Packages, ffmpeg_3 }: | |||
{ lib, python3Packages, pythonAtLeast, ffmpeg }: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're still referring to ffmpeg_3
down in makeWrapperArgs
which is causing this to fail.
Also you don't need the pythonAtLeast
arg here anymore.
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
d4ed37b
to
81fc80a
Compare
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)