Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sudo: 1.8.31p1 -> 1.9.0 #88768

Closed
wants to merge 1 commit into from
Closed

sudo: 1.8.31p1 -> 1.9.0 #88768

wants to merge 1 commit into from

Conversation

r-ryantm
Copy link
Contributor

Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/sudo/versions.

meta.description for sudo is: "A command to run commands as root"

meta.homepage for sudo is: "https://www.sudo.ws/"

Updates performed
  • Version update
To inspect upstream changes
Impact
Checks done (click to expand)
Rebuild report (if merged into master) (click to expand) 
382 total rebuild path(s)

136 package rebuild(s)

136 x86_64-linux rebuild(s)
121 i686-linux rebuild(s)
4 x86_64-darwin rebuild(s)
121 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
bareos
ceph
ceph-client
ceph-dev
collectd
collectd-data
deepin.dde-api
deepin.dde-control-center
deepin.dde-daemon
deepin.dde-dock
deepin.dde-file-manager
deepin.dde-kwin
deepin.dde-launcher
deepin.dde-session-ui
deepin.deepin-desktop-base
deepin.deepin-desktop-schemas
deepin.deepin-wallpapers
deepin.startdde
docker-machine-kvm
docker-machine-kvm2
easysnap
gnome3.gnome-boxes
grub2
grub2_efi
grub2_full
grub2_pvgrub_image
grub2_xen
haskellPackages.libvirt-hs
haskellPackages.libzfs
interlock
libceph
libguestfs
libguestfs-with-appliance
libvirt
libvirt-glib
libvirt_5_9_0
libvmi
linuxPackages-libre.zfs
linuxPackages-libre.zfsStable
linuxPackages-libre.zfsUnstable
linuxPackages.zfs
linuxPackages.zfsStable
linuxPackages.zfsUnstable
linuxPackages_4_14.zfs
linuxPackages_4_14.zfsStable
linuxPackages_4_14.zfsUnstable
linuxPackages_4_19.zfs
linuxPackages_4_19.zfsStable
linuxPackages_4_19.zfsUnstable
linuxPackages_4_4.zfs
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/fc1x2sxf0n11nlj06625ksjvvak329ka-sudo-1.9.0 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A sudo https://github.com/r-ryantm/nixpkgs/archive/859cda057d6ca9d5d2784c7d8a24749b3add3c4f.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/fc1x2sxf0n11nlj06625ksjvvak329ka-sudo-1.9.0
ls -la /nix/store/fc1x2sxf0n11nlj06625ksjvvak329ka-sudo-1.9.0/bin

Pre-merge build results

NixPkgs review skipped

Maintainer pings

cc @edolstra for testing.

@ofborg ofborg bot requested a review from edolstra May 24, 2020 11:16
@nh2
Copy link
Contributor

nh2 commented Jun 3, 2020

Some potentially important changes from https://www.sudo.ws/stable.html#1.9.0:

  • The command line arguments in the SUDO_COMMAND environment variable are now truncated at 4096 characters. This avoids an Argument list too long error when executing a command with a large number of arguments. Bug beret: Fix build on darwin #923 and Debian bug #596631.

The change to now silently truncate feels a bit odd (e.g. potentially not a good idea, as silent truncation almost always is), I've asked for clarificaiton in https://bugzilla.sudo.ws/show_bug.cgi?id=923#c6.

Other potentially relevant behaviour changes mentioned:

  • For sudo -i, if the target user's home directory does not exist, sudo will now warn about the problem but run the command in the current working directory. Previously, this was a fatal error. Debian bug #598519.
  • Sudo command line options that take a value may only be specified once. This is to help guard against problems caused by poorly written scripts that invoke sudo with user-controlled input. Bug cogl: fix build on darwin #924.

@r-ryantm r-ryantm closed this Jun 11, 2020
@r-ryantm r-ryantm deleted the auto-update/sudo branch June 11, 2020 04:56
@ryantm ryantm restored the auto-update/sudo branch June 11, 2020 05:16
@ryantm ryantm reopened this Jun 11, 2020
@r-ryantm r-ryantm closed this Jun 14, 2020
@r-ryantm r-ryantm deleted the auto-update/sudo branch June 14, 2020 03:31
@ryantm ryantm restored the auto-update/sudo branch June 14, 2020 04:22
@ryantm ryantm reopened this Jun 14, 2020
@r-ryantm r-ryantm closed this Jul 1, 2020
@r-ryantm r-ryantm deleted the auto-update/sudo branch July 1, 2020 04:40
@ryantm ryantm restored the auto-update/sudo branch July 1, 2020 04:45
@ryantm ryantm reopened this Jul 1, 2020
@drewrisinger
Copy link
Contributor

Note that the latest sudo version is 1.9.1. https://www.sudo.ws/stable.html#1.9.1

@FRidh FRidh added this to the 20.09 milestone Aug 4, 2020
@dasj19
Copy link
Contributor

dasj19 commented Aug 10, 2020

There is also my PR, opened a month ago and updated today. #93100

This was referenced Oct 6, 2020
Closed
Merged
@r-ryantm r-ryantm deleted the auto-update/sudo branch October 10, 2020 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevincox kevincox kevincox approved these changes

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500
Projects
None yet
Milestone
20.09
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@r-ryantm @nh2 @drewrisinger @dasj19 @kevincox @ryantm @FRidh