use crate2nix #499
Merged
use crate2nix #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems like the latest crate2nix depends on some changes to the rust
infrastructure in nixpkgs.
error: cannot coerce null to a string, at pkgs/build-support/rust/build-rust-crate/configure-crate.nix:33:4
Crate2nix hasn't been added to nixpkgs yet so it needs to be pulled in separately.
|
Yeah, but this is how it was before. Doesn't it make sense to ensure everything actually builds before updating? |
|
I would argue it is time to fix that nix-shell shebang to contain the build
dependencies.
…On Sun, May 24, 2020, 2:41 PM Daiderd Jordan ***@***.***> wrote:
Yeah, but this is how it was before. Doesn't it make sense to ensure
everything actually builds before updating?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#499 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAE365FQF2CDCZAWTCVQ3PTRTEIWHANCNFSM4NI3EFKA>
.
|
cole-h
requested changes
May 24, 2020
cole-h
approved these changes
May 24, 2020
This works with --pure now so it doesn't depend on having anything installed outside of the nix-shell shebang anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've run into various issues with carnix, some have been patched already but I'm not sure how to fix other issues like #498. Crate2nix seems to handle all of the cases we have ran into so far.