Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/chromium: add example and update description #88744

Merged
merged 1 commit into from Jun 1, 2020
Merged

nixos/chromium: add example and update description #88744

merged 1 commit into from Jun 1, 2020

Conversation

davidak
Copy link
Member

@davidak davidak commented May 24, 2020

Motivation for this change

Preview

Screenshot from 2020-05-24 06 13 20

Things done
  • Tested example on stable channel
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • [] macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@davidak davidak changed the title nixos/chromium: add example and update URL nixos/chromium: add example and update description May 24, 2020
@Lassulus Lassulus merged commit 29062ce into NixOS:master Jun 1, 2020
@davidak davidak deleted the chromium-example branch June 1, 2020 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puzzlewolf puzzlewolf puzzlewolf left review comments

@bjornfor bjornfor bjornfor approved these changes

@NickHu NickHu NickHu approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@davidak @bjornfor @NickHu @puzzlewolf @Lassulus