Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emacs2nix: update to fix org elpa update script #87125

Merged
merged 2 commits into from May 6, 2020
Merged

emacs2nix: update to fix org elpa update script #87125

merged 2 commits into from May 6, 2020

Conversation

collares
Copy link
Member

@collares collares commented May 6, 2020

Motivation for this change

Updating emacs2nix to pick up nix-community/emacs2nix@d4c52a7. This should fix https://github.com/nix-community/emacs-overlay/blob/8a24b86c799c386b264a4d2846846d43b75afaa3/default.nix#L98.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@collares collares requested a review from adisbladis as a code owner May 6, 2020 18:10
@collares collares changed the title Emacs2nix emacs2nix: update to fix org elpa update script May 6, 2020
@adisbladis adisbladis merged commit 6dc5d17 into NixOS:master May 6, 2020
@collares collares deleted the emacs2nix branch May 6, 2020 19:29
@adisbladis
Copy link
Member

Thanks for this!

@collares collares mentioned this pull request May 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisbladis adisbladis Awaiting requested review from adisbladis

Assignees
No one assigned
Labels
6.topic: emacs 10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@collares @adisbladis @Janik-Haag