Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ghcHEAD: 20200403 -> 20200505 #86964

Merged
merged 2 commits into from May 6, 2020
Merged

ghcHEAD: 20200403 -> 20200505 #86964

merged 2 commits into from May 6, 2020

Conversation

ggreif
Copy link
Contributor

@ggreif ggreif commented May 5, 2020 •
edited

Motivation for this change

I couldn't resist when seeing the date...

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from peti and kosmikus May 5, 2020 17:15
@ggreif
Copy link
Contributor Author

ggreif commented May 5, 2020

@GrahamcOfBorg build haskell.compiler.ghcHEAD

turion
turion approved these changes May 5, 2020
View reviewed changes
Copy link
Contributor

@turion turion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. When it builds, I can test quickly.

@turion
Copy link
Contributor

turion commented May 5, 2020

Superficially tested ghc, runghc, ghci.

@ggreif
Copy link
Contributor Author

ggreif commented May 5, 2020

Works handsomely on macOS.

@ggreif ggreif marked this pull request as ready for review May 5, 2020 21:53
@ggreif ggreif requested a review from cdepillabout as a code owner May 5, 2020 21:53
@cdepillabout
Copy link
Member

Looks good. Thanks @ggreif for always keeping this up to date.

@cdepillabout cdepillabout merged commit b57119a into NixOS:haskell-updates May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turion turion turion approved these changes

@peti peti Awaiting requested review from peti

@kosmikus kosmikus Awaiting requested review from kosmikus

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

Assignees
No one assigned
Labels
6.topic: haskell 8.has: documentation 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ggreif @turion @cdepillabout