Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kops: 1.15.2 -> 1.15.3 and 1.16.1 -> 1.16.2 #87068

Merged
merged 2 commits into from
May 6, 2020
Merged

kops: 1.15.2 -> 1.15.3 and 1.16.1 -> 1.16.2 #87068

merged 2 commits into from
May 6, 2020
+4 −4

Conversation

kampka
Copy link
Contributor

@kampka kampka commented May 6, 2020

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

kampka added 2 commits May 6, 2020 09:34
@kampka
kops_1_15: 1.15.2 -> 1.15.3

Verified

This commit was signed with the committer’s verified signature. The key has expired.
mweinelt Martin Weinelt
GPG key ID: BD4AA0528F63F17E
Expired
Verified
Learn about vigilant mode
8bcf7f6
@kampka
kops_1_16: 1.16.1 -> 1.16.2

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
7d2a50a
@kampka
Copy link
Contributor Author

kampka commented May 6, 2020

@GrahamcOfBorg build kops_1_15
@GrahamcOfBorg build kops_1_16

@kampka kampka requested a review from Mic92 May 6, 2020 07:50
@ofborg ofborg bot requested review from offlinehacker and zimbatm May 6, 2020 07:57
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels May 6, 2020
@zimbatm zimbatm merged commit 7e66125 into NixOS:master May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92

@offlinehacker offlinehacker

@zimbatm zimbatm

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kampka @zimbatm