Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

monitor: 0.7.1 -> 0.7.2 #86983

Merged
merged 2 commits into from May 9, 2020
Merged

monitor: 0.7.1 -> 0.7.2 #86983

merged 2 commits into from May 9, 2020

Conversation

xiorcale
Copy link
Contributor

@xiorcale xiorcale commented May 5, 2020

Motivation for this change

see: https://github.com/stsdc/monitor/releases/tag/0.7.2

(As a side note, I changed my GitHub username without thinking about the side effect it would have on the nixpkgs I maintain. Should I make a pull request to update it, or leave it as it is now ? As I've understood, people can always find me through my GitHub id anyway)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from worldofpeace May 5, 2020 20:02
@worldofpeace
Copy link
Contributor

(As a side note, I changed my GitHub username without thinking about the side effect it would have on the nixpkgs I maintain. Should I make a pull request to update it, or leave it as it is now ?

It would be great if that attribute was the same as your github username.

@xiorcale
Copy link
Contributor Author

xiorcale commented May 5, 2020

Can i do this in this PR or is it cleaner if I open a new one specifically for that and then update this one once it's merged ?

@ryantm
Copy link
Member

ryantm commented May 8, 2020

@xiorcale It is okay to do it in this PR, but it should be a separate commit.

@FRidh FRidh merged commit ccfe14c into NixOS:master May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xiorcale @worldofpeace @ryantm @FRidh