Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protobuf: 3.7 -> 3.8 #87014

Merged
merged 1 commit into from May 7, 2020
Merged

protobuf: 3.7 -> 3.8 #87014

merged 1 commit into from May 7, 2020

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented May 5, 2020 •
edited

This is needed by newer versions of tensorflow and other ML tools, so we
should start working on an upgrade of the default versoin in the distribution.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bhipple
protobuf: 3.7 -> 3.8
b97f708 
This is needed by newer versions of `tensorflow` and other ML tools, so we
should start working on an upgrade of the default versoin in the distribution.
@drewrisinger
Copy link
Contributor

Thanks for doing this. I ran into an issue with the default version when packaging python3Packages.cirq (requires pythonPackages.protobuf==protobuf>=3.8), and it's difficult to workaround in the Python ecosystem b/c of python environment conflicts.

jonringer
jonringer approved these changes May 7, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have my monster server, so i can't test this, but LGTM

@bhipple
Copy link
Contributor Author

bhipple commented May 7, 2020

Yeah, this would be a fun one to do a big nixpkgs-review on. The upstream release notes look quite tame, though, so I think we'll be fine -- in fact I expect it to solve quite a few problems :)

@bhipple bhipple merged commit 665a260 into NixOS:staging May 7, 2020
@marsam
Copy link
Contributor

marsam commented May 16, 2020

@bhipple do you think we could pin protobuf to protobuf3_11 and use protobuf3_8 just in the tensorflow expression?

@bhipple
Copy link
Contributor Author

bhipple commented May 18, 2020

Sounds reasonable to me, though TBH I'm not that close to the protobuf release stream -- I just see a lot of stuff requires protobuf 3.8+. It might be worth sending a PR and running a big nixpkgs-review on it to see if can just be upgraded.

@drewrisinger
Copy link
Contributor

@bhipple do you think we could pin protobuf to protobuf3_11 and use protobuf3_8 just in the tensorflow expression?

This could cause conflicts if a python environment requires both pythonPackages.protobuf and pythonPackages.tensorflow, depending on which version pythonPackages.protobuf uses.

@marsam marsam mentioned this pull request Jun 25, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bhipple @drewrisinger @marsam @jonringer